0.15に向けたUXやUIの調整 #1719
Merged
0.15に向けたUXやUIの調整 #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Jan 17, 2024
Comment on lines
-152
to
-157
| <span | ||
| v-for="(obj, key) in activePointScrollModeOptions" | ||
| :key="key" | ||
| class="visually-hidden" | ||
| >{{ `「${obj.label}」モードの場合、${obj.desc}` }}</span | ||
| > |
There was a problem hiding this comment.
ここで複数から選択するUIをマウスホバーしないと表示できないツールチップと同じ内容をaria-labelで紹介しているのですが、他の要素と異なるので一旦削除しました。
その代わりこちらにFIXMEコメントを追加しています。
https://github.com/VOICEVOX/voicevox/pull/1719/files#diff-1106a551f0d5f62be2c2917e11f7e47cfd69c9c48d7cc2124f35bbf3aea078a6R311
Hiroshiba
commented
Jan 20, 2024
Comment on lines
-1111
to
1088
| // エディタの＋ボタン表示設定 | ||
| const showAddAudioItemButton = computed( | ||
| () => store.state.showAddAudioItemButton | ||
| ); | ||
| const changeShowAddAudioItemButton = async ( | ||
| showAddAudioItemButton: boolean | ||
| ) => { | ||
| store.dispatch("SET_ROOT_MISC_SETTING", { | ||
| key: "showAddAudioItemButton", | ||
| value: showAddAudioItemButton, | ||
| }); | ||
|
|
||
| // 設定をオフにする場合はヒントを表示 | ||
| if (!showAddAudioItemButton) { | ||
| const result = await store.dispatch("SHOW_CONFIRM_DIALOG", { | ||
| title: "エディタの＋ボタンを非表示にする", | ||
| message: "テキスト欄は Shift + Enter で追加できます", | ||
| actionName: "非表示", | ||
| }); | ||
| if (result === "CANCEL") { | ||
| // キャンセルしたら設定を元に戻す | ||
| store.dispatch("SET_ROOT_MISC_SETTING", { | ||
| key: "showAddAudioItemButton", | ||
| value: true, | ||
| }); | ||
| } | ||
| } | ||
| }; | ||
| const [showAddAudioItemButton, changeShowAddAudioItemButton] = | ||
| useRootMiscSetting("showAddAudioItemButton"); | ||
|
|
There was a problem hiding this comment.
テキスト追加ボタンを非表示にする際に確認ダイアログを出していたのですが、まあ別にいいかなということで確認ダイアログを出さないようにしました。
確認ダイアログの中の文言が結構難しかったためです。
|
多分問題ないと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
まだ完成していませんがメモのためにプルリク作りました。
関連 Issue
resolve #1258
スクリーンショット・動画など
その他