Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

情報ファイルに関するサードパーティ開発者向けドキュメント #1858

Merged
merged 21 commits into from
Mar 6, 2024

Conversation

nmori
Copy link
Contributor

@nmori nmori commented Feb 19, 2024

内容

#1765 で実装した機能についてサードパーティ開発者向けに案内するドキュメントを作成しました
項目の過不足についての相談や、ファイルパスが正しいかなどの相談含め、
多少査読が必要と考えたのでドラフト提出しました。

関連 Issue

ref #1738

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ドラフトPR ありがとうございます!
全体眺めさせていただきました、説明が行き渡ってて問題ないと感じました!!

docs/サードパーティ開発者の方へ.md Outdated Show resolved Hide resolved
docs/サードパーティ開発者の方へ.md Outdated Show resolved Hide resolved
nmori and others added 3 commits February 24, 2024 14:50
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Nanashi. <sevenc7c@sevenc7c.com>
* VOICEVOXの仕組みを追記
@nmori nmori marked this pull request as ready for review February 24, 2024 06:39
@nmori nmori requested a review from a team as a code owner February 24, 2024 06:39
@nmori nmori requested review from Hiroshiba and removed request for a team February 24, 2024 06:39
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!
詳細な情報ありがとうございます!!

docs/サードパーティ開発者の方へ.md Outdated Show resolved Hide resolved
docs/サードパーティ開発者の方へ.md Outdated Show resolved Hide resolved
docs/サードパーティ開発者の方へ.md Outdated Show resolved Hide resolved
nmori and others added 2 commits March 1, 2024 00:29
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

レビュー遅くなってすみません 🙇
プルリクエストありがとうございます!!!

docs/サードパーティ開発者の方へ.md Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit be6e005 into VOICEVOX:main Mar 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants