[refactor] VueRouterの依存を失くす #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-chan
approved these changes
Feb 29, 2024
Hiroshiba
commented
Feb 29, 2024
There was a problem hiding this comment.
レビューありがとうございます！
マージします！！
URLが無効になったことによりブラウザ周りが大きく仕様変更された形になるかもです。
ということで共有です。 @sevenc-nanashi
最初に開くエディタを指定可能にするのは、プロジェクトファイル等と同じく最初に開くべきエディタをURLパラメータで指定するのが良さそう？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VueRouterへの依存をなくします。
依存をなくすことの利点は #1872 に書いている通りです。
関連 Issue
close #1872
その他
vue-routerのために
/#/talkなどに飛ばしているところも変更したつもりです。#/などでもファイル全体検索をかけて該当箇所がなさそうなことは確認しています。