undo/redo時にノートの選択が解除されないのを修正 #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sevenc-nanashi |
Hiroshiba
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
LGTM！！
修正ありがとうございます！
@sevenc-nanashi さんのおっしゃる通り、フィルタリングする形が良いのかなと思いました！
多分undo/redo以外にも選択ノートの妙な変更が実装される可能性があるので、その時に毎回手続き的にselect/deselectしているといつか間違う気がするので、GETTERのが良さそうに感じました。
とりあえず こちらで to do コメントだけ書き換えさせていただいてマージします！
こちらの変更はホットフィックスとして0.17.1に取り込みたいと思います！
Hiroshiba
reviewed
Mar 7, 2024
Hiroshiba
reviewed
Mar 7, 2024
|
こちら忘れないようにissue作成します！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
undo/redo時にノートの選択が解除されておらず、
ADD_NOTESをundoしたときに存在しないノートのIDがselectedNoteIdsに入ってしまっていたので、修正します。その他