Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: prettier、eslint、node、npmを更新 #1992

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Update: prettier、eslint、node、npmを更新 #1992

merged 10 commits into from
Apr 17, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

prettierとeslintを更新します。

関連 Issue

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner April 15, 2024 10:26
@sevenc-nanashi sevenc-nanashi requested review from y-chan and removed request for a team April 15, 2024 10:26
sevenc-nanashi
sevenc-nanashi commented Apr 15, 2024
View reviewed changes
.prettierrc.json Outdated Show resolved Hide resolved
@sevenc-nanashi sevenc-nanashi changed the title Update: prettierとeslintを更新 Update: prettier、eslint、nodeを更新 Apr 15, 2024
@sevenc-nanashi sevenc-nanashi changed the title Update: prettier、eslint、nodeを更新 Update: prettier、eslint、node、npmを更新 Apr 15, 2024
sevenc-nanashi
sevenc-nanashi commented Apr 15, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba reviewed Apr 15, 2024
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba reviewed Apr 15, 2024
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず全ファイルの変更を見比べて問題なさそうなことを確認しました！
ひとつだけコメントしました！

@sevenc-nanashi @Hiroshiba
Code: コメントを追加
9a63b8f 
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Hiroshiba
Hiroshiba approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

プルリクエスト分けていただきありがとうございます！！
また他の更新もじゃんじゃんやっていきたいのでもしよかったら！！

ちょっと一箇所コメントこっちで変えさせていただきます。
あとNodeのバージョンが更新されたので案内issue作ります。

@Hiroshiba Hiroshiba mentioned this pull request Apr 17, 2024
Closed
@Hiroshiba Hiroshiba merged commit 16f5b04 into VOICEVOX:main Apr 17, 2024
8 checks passed
sevenc-nanashi added a commit to sevenc-nanashi/voicevox that referenced this pull request Apr 18, 2024
@sevenc-nanashi @Hiroshiba
Update: prettier、eslint、node、npmを更新 (VOICEVOX#1992)
d033631 
* Update: prettierとeslintを更新

* Update: node、npmを更新

* Change: trailingCommasをallに

* Revert: テスト用のが紛れてた

* Update: Nodeを20に

* Code: 理由を追加

* Change: no-unsafe-declaration-mergingをなくす

* Fix: 型エラーを修正

* Code: コメントを追加

Co-authored-by: Hiroshiba <hihokaruta@gmail.com>

* FIXMEの内容をより細かく

---------

Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
@sevenc-nanashi sevenc-nanashi mentioned this pull request May 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@y-chan y-chan Awaiting requested review from y-chan y-chan was automatically assigned from VOICEVOX/maintainer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenc-nanashi @Hiroshiba