generateLicenses.jsを書き直す #2000
Merged
generateLicenses.jsを書き直す #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Apr 17, 2024
Hiroshiba
reviewed
Apr 17, 2024
Hiroshiba
reviewed
Apr 17, 2024
Comment on lines
-5
to
+6
| const fs = require("fs"); | ||
| const fs = require("fs/promises"); |
There was a problem hiding this comment.
別に良いけど実は不要な変更かも。
nodejsはpromiseの方が推奨されてるとかあったりするなら変更したほうが良さそう。
There was a problem hiding this comment.
メインがasyncになったのでせっかくなので、って感じです。どちらでも良さそう。
There was a problem hiding this comment.
なるほどです、まあ良さそう。
仮に戻すってなった時のこと考えると、どちらでも良いならたぶん変えない方が良さそう。
けどまあpromiseは取り回しやすいし（await忘れが怖いけど）、関数内だからどちらにせよ差分は発生するし、まあ良いかな。
Hiroshiba
reviewed
Apr 17, 2024
Hiroshiba
approved these changes
Apr 18, 2024
sevenc-nanashi
added a commit
to sevenc-nanashi/voicevox
that referenced
this pull request
Apr 28, 2024
* Change: generateLicenses.jsを書き直し * Fix: execFileSync周りの型を修正 * Code: argvを離す * Fix: 細かいところを修正
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue
スクリーンショット・動画など
（なし）
その他
キリ番踏んだので報告します！（）
build下のスクリプト、そのうちTypeScriptに書き換えて安心したい