Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: TypeScriptとViteを更新 #2001

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

TypeScriptとVite(あと@typescript-eslint/下、同じバージョンで揃えた方が良さそうだったので)をアプデします。
また、ViteのコンフィグをESModuleにします。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner April 18, 2024 21:44
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team April 18, 2024 21:44
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます!!ほんとに助かります!!

不勉強であまり知らないところだったのでちょっとコメントしてみました!

vite.config.mts Outdated Show resolved Hide resolved
vite.config.mts Show resolved Hide resolved
vite.config.mts Show resolved Hide resolved
"@voicevox/eslint-plugin": "file:./eslint-plugin",
"@vue/eslint-config-prettier": "9.0.0",
"@vue/eslint-config-typescript": "13.0.0",
"@vue/test-utils": "2.3.0",
"cross-env": "7.0.3",
"cross-var": "1.1.0",
"dotenv": "16.0.0",
"electron": "27.0.3",
"electron-builder": "24.6.4",
"electron": "30.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

メジャーバージョンで3段階進化ですね。
一応それぞれの変更みてきました、特に影響はなさそう…?

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

さてどうなるかですね!!

@Hiroshiba Hiroshiba merged commit 0095deb into VOICEVOX:main Apr 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants