ソング:startFrameがマイナス値になりf0にundefinedが入るバグを修正 #2032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#2031 の修正PRです。
applyPitchEdit
でstartFrame
がマイナス値になり、f0にundefinedが入ってレンダリングに失敗するのを修正します。SequencerPitchの方も
startFrame
がマイナス値になってました…それも修正します。関連 Issue
close #2031
その他
applyPitchEdit
のテストがあれば防げたと思うので、テストを書いていった方が良さそう