Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-redisign-help-dialog]ファイルパスをmainリポジトリに合わせる #2059

Merged

Conversation

takusea
Copy link
Contributor

@takusea takusea commented May 5, 2024

内容

HelpDialog関連のパスをmainリポジトリに合わせます。具体的に以下を行います。

  • component下のtemplate, helpディレクトリにあったHelpDialog関連コンポーネントをDialog/HelpDialogに移動
  • baseディレクトリをBaseディレクトリ(PascalCase)に変更

その他

このプルリクががマージされたらあとはコンフリクト解消等するだけになるかと!

@takusea takusea requested a review from a team as a code owner May 5, 2024 14:20
@takusea takusea requested review from Hiroshiba and removed request for a team May 5, 2024 14:20
@takusea takusea changed the base branch from main to project-redisign-help-dialog May 5, 2024 14:21
@takusea takusea requested a review from a team as a code owner May 5, 2024 14:21
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ちょっとブランチを見て回ったのですが、new-colors.scssはcolorsに統合するなり何かまとめるなりする必要があるかもと思いました!
(相対的なnewという名称は、さらに新しいカラーが出てきた時に困っちゃう)

stylesディレクトリの他のファイルも見たけど良さそうな感じ・・・!

もし何かコメントを思いついたらコメントさせていただきます 🙇

@Hiroshiba Hiroshiba merged commit b6a07dd into VOICEVOX:project-redisign-help-dialog May 10, 2024
@takusea takusea deleted the match-path-to-main branch July 26, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants