Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ハミング/ソングスタイルを使用して作成されてしまったデフォルトプリセットを削除するマイグレーション処理に対してのテストを追加する #2064

Merged
merged 4 commits into from
May 16, 2024
Merged

ハミング/ソングスタイルを使用して作成されてしまったデフォルトプリセットを削除するマイグレーション処理に対してのテストを追加する #2064

merged 4 commits into from
May 16, 2024

Conversation

madosuki
Copy link
Contributor

@madosuki madosuki commented May 7, 2024

内容

関連 Issue

close #2062

スクリーンショット・動画など

その他

@madosuki madosuki requested a review from a team as a code owner May 7, 2024 09:09
@madosuki madosuki requested review from Hiroshiba and removed request for a team May 7, 2024 09:09
Hiroshiba
Hiroshiba reviewed May 12, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！
実装ありがとうございます！！！

tests/unit/backend/common/configManager.spec.ts Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

ちょっとこちらで調整させていただきます！

テスト実装ありがとうございました！！！
結構重要度の高いものでも放置気味になってしまっていて、もしよかったらお力お借りできるともうすごく心強いです！！！

この辺りとか、もしよければ･･･！！！！

tests/unit/backend/common/configManager.spec.ts Outdated Show resolved Hide resolved
tests/unit/backend/common/configManager.spec.ts Outdated Show resolved Hide resolved
tests/unit/backend/common/configManager.spec.ts Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 3f41639 into VOICEVOX:main May 16, 2024
9 checks passed
@madosuki madosuki deleted the add_unit_test_of_migration_from_19_1 branch July 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@madosuki @Hiroshiba