feat: sandboxを有効化 #2074
Merged
feat: sandboxを有効化 #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabonerune
commented
May 11, 2024
Comment on lines
-388
to
-405
| nodeIntegration: false, | ||
| contextIsolation: true, | ||
| sandbox: false, // TODO: 外しても問題ないか検証して外す |
There was a problem hiding this comment.
全部デフォルトはセキュアな方になっているので削除します。
sabonerune
force-pushed
the
feat/enable-sandbox
branch
3 times, most recently
from
8c624f0 to
3b031b9
Compare
sabonerune
force-pushed
the
feat/enable-sandbox
branch
from
3b031b9 to
94924c5
Compare
Hiroshiba
reviewed
Jun 25, 2024
|
あっすみません！！ これってなにかユーザーの使い勝手に変化がある感じでしたっけ 👀 （今思いつきましたが、sudoしてるlinuxとかでは動かなくなるかもですかね） |
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
|
@Hiroshiba Chromiumのサンドボックス化はそれとは別に行われる気がします。 |
あ、そりゃそうか･･･！！ 実際どうかわからないけど、とりあえずdevブランチでビルドしてみましょう･･･！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
プロセスのサンドボックス化を有効化してセキュリティを向上させます。
ref: https://www.electronjs.org/ja/docs/latest/tutorial/sandbox
関連 Issue
その他
preload.jsが分割されていることがそのまま動かすことができないことの原因でした。https://electron-vite.github.io/guide/preload-not-split.html
#2071 (comment) で触れて作業を開始したのですが本当に直接的に関係なかったかもしれません。
--no-sandboxを付けてもpreload.jsが分割された状態では正常に動作しませんし、この機能を有効化してもUbuntu24.04(VirtualBox上)で--no-sandboxを付けて起動させることができました。