Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

マルチトラック：storeを色々変える #2093

Merged
merged 36 commits into from
Jun 2, 2024
Merged

マルチトラック：storeを色々変える #2093

merged 36 commits into from
Jun 2, 2024
+535 −255

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通りです。

関連 Issue

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner May 22, 2024 12:38
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team May 22, 2024 12:39
@sevenc-nanashi sevenc-nanashi mentioned this pull request May 22, 2024
Closed
3 tasks
@sevenc-nanashi sevenc-nanashi marked this pull request as draft May 22, 2024 12:48
@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review May 22, 2024 12:54
Hiroshiba
Hiroshiba reviewed May 24, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

プルリクエストの切り分けありがとうございます！！
全体的に良い感じなのかなと思いましたが、一部設計に関わってきそうなところをコメントさせていただきました！

store/singingについていた型が消えまくっているので、そこは @sigprogramming さん的に問題なければ良いかなと思います。
type.tsの方にあるのが自動で割あたっている感じです。
分かりづらいとかであれば戻していただく形が良さそう。

（ちなみにsinging.tsの中でもコマンド系統はすでに型が書いてないのがちらほらありました）

個人的には data やundefinable型など、一部何を示しているのかわからないものは型書いてあるとバグを埋め込みづらいかもなーとちょっと思いました！

src/store/type.ts Outdated Show resolved Hide resolved
src/store/project.ts Show resolved Hide resolved
src/store/project.ts Outdated Show resolved Hide resolved
src/store/project.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
@sevenc-nanashi sevenc-nanashi marked this pull request as draft May 25, 2024 10:17
@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review May 27, 2024 11:33
@sevenc-nanashi
Copy link
Member Author

改修が終わりました。

sigprogramming
sigprogramming reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CREATE_TRACKのところまでレビューしました！
mutationやactionの引数の型が消えているのは問題ないと思います！

src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba reviewed May 30, 2024
View reviewed changes
src/store/singing.ts Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba reviewed May 31, 2024
View reviewed changes
src/store/singing.ts Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！！！！！

phraseにtrackId持たせると一気に可読性上がったなと感じました！！
変更大変だったと思います、ありがとうございます！！！！

@sig さんのレビューでいろいろ変わったらまたレビューしますので、気軽にレビュー request いただけると！

sevenc-nanashi and others added 4 commits May 31, 2024 10:13
@sevenc-nanashi @Hiroshiba
Change: Mapのキーを変える
6315e46 
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
@sevenc-nanashi
Change: CREATE_TRACKをADD_TRACKと分割
57ee262
@sevenc-nanashi @Hiroshiba
Code: 空行を開ける
09a5da8 
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
@sevenc-nanashi
Change: overlappingNoteIdsをトラック毎に持つようにする
d51eb36
sigprogramming
sigprogramming reviewed Jun 1, 2024
View reviewed changes
Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一通りレビューしました！

src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Show resolved Hide resolved
src/store/singing.ts Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/store/singing.ts Show resolved Hide resolved
src/store/singing.ts Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
@sevenc-nanashi
Copy link
Member Author

レビューを反映しました。

sigprogramming
sigprogramming approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

src/sing/domain.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
@Hiroshiba
Copy link
Member

マージします！！　実装＆レビューありがとうございました！！

@Hiroshiba Hiroshiba merged commit 642a354 into VOICEVOX:project-multitrack Jun 2, 2024
9 checks passed
@sevenc-nanashi sevenc-nanashi mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprogramming sigprogramming sigprogramming approved these changes

@Hiroshiba Hiroshiba Awaiting requested review from Hiroshiba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevenc-nanashi @Hiroshiba @sigprogramming