Refactor: v-for1つでノートを描画する形に変更し、ダブルクリック判定処理を無くす #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
commented
Jun 9, 2024
| contextMenu.value?.hide(); | ||
| await store.dispatch("COPY_NOTES_TO_CLIPBOARD"); | ||
| }, | ||
| disabled: !isNoteSelected.value, |
There was a problem hiding this comment.
isNoteSelectedがリアクティブなので、contextMenuDataをcomputedにしました。
sigprogramming
changed the title
Hiroshiba
reviewed
Jun 17, 2024
Hiroshiba
approved these changes
Jun 17, 2024
Comment on lines
+59
to
+61
| <SequencerLyricInput | ||
| v-if="editingLyricNote != undefined" | ||
| :editingLyricNote |
There was a problem hiding this comment.
（コンポーネント設計うんちくです）
表示の切り替え方法について、v-ifにするパターンと、props.editingLyricNoteをundefinedableにしてSequencerLyricInput内でコンポーネント内で表示非表示を切り替えるパターンがあり、どちらが良いか迷ってました。
今回はv-ifでも良さそうでした！
というのも、v-ifを使うとtrue/falseが切り替わったタイミングでコンポーネント内のstateが消えるんですよね。
v-ifの場合、もし歌詞入力中に一度SequencerLyricInputを非表示にすると、入力中の歌詞が消えるなぁと。
今回の場合は歌詞入力が消えてほしくないタイミングでv-ifで消すことがないので、どちらでも大丈夫そう！
|
レビューありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
v-for1つでノートを描画する形に変更し、ダブルクリック判定処理を無くします。
また、以下も行います。
onNoteLyricMouseDownを削除する関連 Issue
ref #2041
その他
ノート編集時の動作が若干重くなってるかもです…