Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-redisign-help-dialog] デザインの微調整 #2149

Conversation

takusea
Copy link
Contributor

@takusea takusea commented Jul 1, 2024

内容

HelpDialogのデザインの微調整として、DocumentViewのスタイルの調整と色変数のミスの修正を行います。

  • 具体的なDocumentViewのスタイルの調整
    • detailsタグのスタイルの追加
      • image
    • 2階層目以降のul,olタグの不要な空白の除去
    • pre要素の見た目調整
    • paddingとborder-radiusをSCSS変数を用いるように変更

@takusea takusea requested a review from a team as a code owner July 1, 2024 12:00
@takusea takusea requested review from Hiroshiba and removed request for a team July 1, 2024 12:00
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

すっごい見やすくなったと思います、ありがとうございます!!!!!

@Hiroshiba Hiroshiba merged commit bb22dc0 into VOICEVOX:project-redisign-help-dialog Jul 1, 2024
9 checks passed
@Hiroshiba
Copy link
Member

ちなみにデザインの調整ですが、昔のデザインは本当にとりあえずで作ったものだったので、カリカリにチューニングしていただいてOKです!!
もし前のパディング幅とかを尊重してくださってたら、ぜひぜひ破壊しちゃってください!!

@takusea takusea deleted the tweak-document-view-styles branch July 26, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants