Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
マルチトラック:最終調整 #2176
マルチトラック:最終調整 #2176
Changes from 28 commits
abdd921
009b89a
e59454e
5dc4c01
c71d9c8
47c9c28
4ab7c67
3af1168
fd9e256
8da3ae5
a3ee7fc
a8db0ca
a31cabe
9dc0d9d
f801a18
0d9e6eb
0792525
2efc9c3
cf66bc3
93e5a4f
4b9806f
c24d5d7
73c3411
15409f9
32dd8fb
4c27d3e
42710c6
40741d9
619c045
6aca4bd
2fff4d5
65525fc
6645f5c
80d9ab7
a3db2c2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こーーーーーーーーれってなんででしたっけ。。。
一応ここのコメントにメモだけ残しておきたく。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ2つに分けた理由って何でしたっけ。
phraseInfosInOtherTracks
とphraseInfosInSelectedTrack
をtemplateの中でくっつけた後:isInSelectedTrack="phraseInfo.trackId === selectedTrackId"
で判定させる手もありそう。なんか色々あった結果そういうこともできるようになったんでしたっけ。
それとも意図あってこうなったんでしたっけ。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(別にこれでもいいんですが)
たぶんreduceでmax書けるはず。