Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

マルチトラック:複数選択が出来ないのを修正 #2186

Conversation

sevenc-nanashi
Copy link
Member

内容

複数選択が出来ないのを修正します。

関連 Issue

スクリーンショット・動画など

(なし)

その他

やっぱりtoRawしばりたくなってきた(structuredClone(toRaw())はcloneWithUnwrapProxyで代替できるので)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner July 29, 2024 21:14
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team July 29, 2024 21:14
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

早速ありがとうございます 🙇

・・・・・・・?
なんでこれで解決するんだろう(というよりなんで問題が起こってたんだろう)

@Hiroshiba Hiroshiba merged commit d5f6825 into VOICEVOX:project-multitrack Jul 30, 2024
9 checks passed
@sevenc-nanashi
Copy link
Member Author

多分:
ObjectとかArrayとかSetの使用検知はstateのプロパティ取得じゃなく.addとかRustで言う.iter()についてて、それを呼ぶ前にtoRawしたから検知がされなかったんだと思います
まぁtoRawは悪ということで…

@Hiroshiba
Copy link
Member

あーーーーなんとなくわかったかもです。
こーーーれはむずいですね。。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants