Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の解決プルリクエストです。
バッファ変数を作っていて、そのバッファ変数が変わった時にstoreの方に変わった方の値を投げないといけないのですが、storeの方の値を投げていたのが原因でした。
なのでバッファ変数（＝表示される値）だけ変わっていて、保存されていなかった感じでした。
関連 Issue
fix #2198
その他
これ気づけなかったの申し訳ないですねぇ･･･。
バッファ変数作ってちょっと特殊だったから、テストを書いても良かったのかもしれない。けどまあ･･･。
1回実行チェックしておくべきだったかもしれない。