Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

読み方&アクセント辞典: click イベントハンドラで editWord() / deleteWord() の前に selectWord(key) を実行する。 #2207

Merged

Conversation

honey32
Copy link
Contributor

@honey32 honey32 commented Aug 6, 2024

内容

関連 issue で報告された不具合の解消

選択せずホバーで「編集」「削除」ボタンが表出された場合のために、そのボタンの click イベントハンドラで editWord() / deleteWord() の前に selectWord(key) を実行する。

関連 Issue

close #2196

スクリーンショット・動画など

その他

@honey32 honey32 requested a review from a team as a code owner August 6, 2024 13:35
@honey32 honey32 requested review from Hiroshiba and removed request for a team August 6, 2024 13:35
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

修正ありがとうございます!!

@Hiroshiba Hiroshiba merged commit 1460376 into VOICEVOX:main Aug 6, 2024
9 checks passed
@honey32 honey32 deleted the fix/24-0806-select-word-before-edit branch August 7, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants