errorToMessage関数追加し、createLoggerの処理を変更して、eslintのルールを１つ採用 #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
force-pushed
the
errorToMessage作る
branch
from
a2b10ad to
5d42154
Compare
Hiroshiba
commented
Aug 11, 2024
Hiroshiba
commented
Aug 11, 2024
| throw new Error(`Key not found: ${key}`); | ||
| throw new Error(`Key not found: ${String(key)}`); |
There was a problem hiding this comment.
元のコードだとSymbolが来たときにエラーになってた
Hiroshiba
changed the title
Hiroshiba
commented
Aug 11, 2024
Comment on lines
4
to
9
| const createInner = | ||
| (method: "logInfo" | "logError" | "logWarn") => | ||
| (...args: unknown[]) => { | ||
| window.backend[method](`[${scope}] ${args[0]}`, ...args.slice(1)); | ||
| window.backend[method](`[${scope}]`, ...args); | ||
| }; | ||
| return { |
There was a problem hiding this comment.
ここの処理変更によって、console.logだとなんかいい感じに表示される"%o", 25のような書式が使えなくなってしまいます。
たぶん現コードのどこにも使われてないけれども、この変更していいのかが判断しづらい。。
（テンプレート文字列の方が使いやすい気はする）
|
レビューありがとうございます！マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
こちらのコメントでやり取りしていた内容です。
errorToMessage関数を作って、あとロガーをちょっと改造して
toString()メソッドがなくても大丈夫なようにしました。これによってeslintで例外にしていたルールを1つ採用できます。
ちなみにテンプレート文字列に突っ込む時、String関数でラップするのとしないのとでは若干挙動が違うらしい。
https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/String#%E6%96%87%E5%AD%97%E5%88%97%E3%83%97%E3%83%AA%E3%83%9F%E3%83%86%E3%82%A3%E3%83%96%E3%81%A8_string_%E3%82%AA%E3%83%96%E3%82%B8%E3%82%A7%E3%82%AF%E3%83%88
String関数を使うとSymbolもそれっぽい文字列にしてくれるらしいけど、テンプレート文字列（
.toString()？）だとエラーになるらしい。関連 Issue
スクリーンショット・動画など
その他