Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テキスト未選択時にコンテキストメニューヘッダーを非表示にする #2222

Merged

Conversation

jdkfx
Copy link
Contributor

@jdkfx jdkfx commented Aug 14, 2024

内容

  • トークエディタ画面で右クリックメニューを使用する際、テキスト未選択時にコンテキストメニューヘッダー上で過去に選択したテキストが表示されるバグを解消

関連 Issue

#2156 (comment)

スクリーンショット・動画など

修正前

2024-08-15.3.49.54.mov

修正後

2024-08-15.3.44.39.mov

その他

@jdkfx jdkfx requested a review from a team as a code owner August 14, 2024 18:52
@jdkfx jdkfx requested review from Hiroshiba and removed request for a team August 14, 2024 18:52
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ありがとうございました!!

@@ -634,6 +634,7 @@ const readyForContextMenu = () => {
isRangeSelected.value = false;
getMenuItemButton("切り取り").disabled = true;
getMenuItemButton("コピー").disabled = true;
contextMenuHeader.value = "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あーーなるほどです!!

これもしかしたら下にあるifの場所を変更する手もありそうですね。
ちょっと別でそういう感じのプルリクエストを出してみようと思います!!

@Hiroshiba Hiroshiba merged commit 332a2a7 into VOICEVOX:main Aug 15, 2024
9 checks passed
@jdkfx jdkfx deleted the fix/hide_header_when_text_is_not_selected branch November 27, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants