Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ソングのスクショも追加 #2280

Conversation

Hiroshiba
Copy link
Member

内容

ソング画面の最初のところもスクショテスト配置してみました。
どう変わったかが分かりやすいかなと!

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner October 1, 2024 16:40
@Hiroshiba Hiroshiba marked this pull request as draft October 1, 2024 17:56
@Hiroshiba Hiroshiba marked this pull request as ready for review October 1, 2024 17:56
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あれキャラクター写ってない・・・・
と思ったけどそうか、ソング対応のキャラクターがNemoにいないからか・・・。

スケルトンの部分がアニメーションになってて不安だったんですが、見た感じいい感じにアニメーションしないようにされてそう?
なので良さそう!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そういえば左上のキャラクター欄の見た目がちょっと変ですね…

Copy link
Member Author

@Hiroshiba Hiroshiba Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これテスト時はアニメーションしてないだけ・・・みたいな感じなのかもとかちょっと思いました
(こっちでもコメントしてました #2280 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、スケルトンが重なってるところですね...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、なるほど! たしかに!

@Hiroshiba
Copy link
Member Author

こちらも多分問題ないと思うのでマージします!

@Hiroshiba Hiroshiba merged commit 3a1f664 into VOICEVOX:main Oct 19, 2024
8 checks passed
@Hiroshiba Hiroshiba deleted the ソングのスクリーンショットを撮影する branch October 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants