Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ポート変更時に
EngineInfo
の情報を書き換えないようにする。 #2282refactor: ポート変更時に
EngineInfo
の情報を書き換えないようにする。 #2282Changes from 1 commit
74b5d5b
a660b39
2efb03d
923ef71
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HostInfo.port、Numberじゃなくてstringでも良さそうな気がしますね!
まあとはいえEngineManifestのportがnumberなので全部stringにはできないですね。
まあどこからstringにするかというだけですが、このエディタ上では大体stringで統一しておくと良さそうかも?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
portHelper周りがNumberで処理しているのでここがNumberとStringを切り替える部分だと思いました。
メモ: portHelper周りをStringに書き換える場合portが数字であることを確認しないとOSコマンドインジェクション脆弱性を引き起こすかもしれない。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです!!
portHelper周りもstringで良い気もしました!
けどまあ、既存コードになじませる意図だとNumberのが良さそうなので、このプルリクエストはこの形が良さそうだなと感じました!!
ということでresolve!
現状、engineManifestの読み込みは型のバリデーションも含むzodで行っているので、必ず数値しか入らないと思われます。
ちょっとこのプルリクとは外れますが、危ないのは事実ですね・・・。
一番危ないのはたぶんコマンド実行している部分execFileSyncが
shell: true
で動いてることだと思います。hostnameとかでいたずらされるかもしれない。shell: false
にすれば問題ないはず・・・。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ただのコメントです)
仮にdefaultPortがundefinableになっても、ここは必ずstringになりそう!