Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

マルチトラック:デフォルトで有効にする #2285

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

これと言ったバグが報告されていないので、マルチトラックをデフォルトで有効にします。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner October 7, 2024 08:50
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team October 7, 2024 08:50
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

テスト落ちてそうだけど。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ @takusea さんのPRと被ってそうなのでご報告です 🙏

変更点は2つです。

  1. 「ソング:マルチトラック機能」のセルが消えた
  2. experimentalSetting.enableMultiTrackで表示を切り替えていたのが消えた

src/store/project.ts Outdated Show resolved Hide resolved
src/store/singing.ts Show resolved Hide resolved
src/type/preload.ts Show resolved Hide resolved
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

いやースクショ更新便利ですね!!!
なんか/update-screenshotとかで起動するようなbotとか導入できないかな。

@Hiroshiba Hiroshiba merged commit a1ace78 into VOICEVOX:main Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants