StorybookのVRTをPlaywrightでやる #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
[update snapshots]
|
正直完結させる必要性が思い浮かばないんですよね… |
Hiroshiba
reviewed
Oct 14, 2024
Hiroshiba
reviewed
Oct 14, 2024
Hiroshiba
reviewed
Oct 14, 2024
There was a problem hiding this comment.
良さそう！！
こちらのコメントも見ていただけると…！すみません！！
https://github.com/VOICEVOX/voicevox/pull/2291/files#r1798550275
軽く試しましたが明らかに茨の道だったので諦めます... |
|
うおお、ありです。。。まだまだ道は長いか。。。 |
Hiroshiba
reviewed
Oct 14, 2024
sevenc-nanashi
changed the title
Hiroshiba
reviewed
Oct 14, 2024
Hiroshiba
reviewed
Oct 14, 2024
Co-Authored-By: hiroshiba <hiroshiba@users.noreply.github.com>
Hiroshiba
reviewed
Oct 14, 2024
Hiroshiba
reviewed
Oct 14, 2024
Hiroshiba
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
LGTM！！！
ちょっとスクリーンショットのサイズが大きいので、なんか調整したい気持ちがちょっとありますね！
Storybook側で設定していくと一覧性が上がって良いかもしれない。
このviewportで設定できるかも。
https://storybook.js.org/docs/essentials/viewport#configuring-per-component-or-story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
StorybookのVRTをPlaywrightで行う実験です。
#2289 からの派生です。
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）