Refactor: SequencerRulerをContainer/Presentationに分離 #2312
Merged
+170
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
[update snapshots]
Hiroshiba
reviewed
Oct 23, 2024
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Hiroshiba
approved these changes
Oct 23, 2024
Comment on lines
40
to
43
| args: { | ||
| "onUpdate:playheadTicks": fn<(value: number) => void>(), | ||
| onDeselectAllNotes: fn(), | ||
| }, |
There was a problem hiding this comment.
基本全部meta.argsに突っ込むのがベストかな〜〜〜と思ってます！
追加で必要になったときにコピペしないといけないので、デフォルト挙動としてmeta.argsに置いとくのが良さそうかなと。
まあそれが正解かわからんですが、一旦他のstoriesはそうなってるので合わさせていただきます！
（個別のが良いなってなったら全部そうしちゃいましょう！！）
|
マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通りです。
関連 Issue
スクリーンショット・動画など
（なし）
その他