Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

承諾系のダイアログのリデザイン #2315

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

takusea
Copy link
Contributor

@takusea takusea commented Oct 24, 2024

内容

VOICEVOX初起動時に表示される承諾系のダイアログ(AcceptRetrieveTelemetryDialog・AcceptTermsDialog)のリデザインを行います。
それに伴い、レイアウトをAcceptDialogコンポーネントへ切り出して共通化し、各ファイルをcomponents/Dialog/AcceptDialog/下に移動しています。

スクリーンショット・動画など

image
image

@takusea takusea requested a review from a team as a code owner October 24, 2024 13:42
@takusea takusea requested review from Hiroshiba and removed request for a team October 24, 2024 13:42
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

今回のsrc/components/Dialog/AcceptDialog/AcceptDialog.vueとかはかなりStorybookと相性良い構成になってるかもです!!

スクショテストもされるようになっていていろいろ気づけると思うので、もし気が向けばぜひ 🙏
(簡単に確認できるので便利&便利そう)

@Hiroshiba Hiroshiba merged commit 4f230a5 into VOICEVOX:main Oct 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants