-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContextMenuをContainer/Presentationに分離する #2376
ContextMenuをContainer/Presentationに分離する #2376
Conversation
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no suggestions.
Files not reviewed (5)
- src/components/Dialog/DictionaryManageDialog.vue: Evaluated as low risk
- src/components/Menu/ContextMenu/Container.vue: Evaluated as low risk
- src/components/Menu/ContextMenu/Presentation.vue: Evaluated as low risk
- src/components/Sing/PlayheadPositionDisplay.vue: Evaluated as low risk
- src/components/Sing/ScoreSequencer.vue: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM・・・なんですが、これもしかしたらContainer要らないかも・・・?
ContainerはPresentationのバイパスをしつつuiLockedを足してるだけなので。
ただまあ別PRもあってここは本題ではないといえばそうなので、合図いただければマージします!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
ContextMenu/Containerがあったほうが良いか無くてよいかわからないですね・・・。
ちょっと今回はありパターンで進んでみますか!
内容
タイトル通りです。
関連 Issue
スクリーンショット・動画など
(なし)
その他
(なし)