Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextMenuをContainer/Presentationに分離する #2376

Merged

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通りです。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner November 22, 2024 09:15
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team November 22, 2024 09:15
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Nov 22, 2024

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:a785026

@Hiroshiba Hiroshiba requested a review from Copilot November 22, 2024 09:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no suggestions.

Files not reviewed (5)
  • src/components/Dialog/DictionaryManageDialog.vue: Evaluated as low risk
  • src/components/Menu/ContextMenu/Container.vue: Evaluated as low risk
  • src/components/Menu/ContextMenu/Presentation.vue: Evaluated as low risk
  • src/components/Sing/PlayheadPositionDisplay.vue: Evaluated as low risk
  • src/components/Sing/ScoreSequencer.vue: Evaluated as low risk
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM・・・なんですが、これもしかしたらContainer要らないかも・・・?

ContainerはPresentationのバイパスをしつつuiLockedを足してるだけなので。

ただまあ別PRもあってここは本題ではないといえばそうなので、合図いただければマージします!

src/components/Menu/ContextMenu/Container.vue Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ContextMenu/Containerがあったほうが良いか無くてよいかわからないですね・・・。
ちょっと今回はありパターンで進んでみますか!

src/components/Menu/ContextMenu/Container.vue Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit a6a4c21 into VOICEVOX:main Nov 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants