Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview-pagesをREADMEに追記する #2382

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通りです。

Chromatic、捨てても良いかも?

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner November 29, 2024 10:27
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team November 29, 2024 10:27
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Nov 29, 2024

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:c0cc845

@Hiroshiba Hiroshiba requested a review from Copilot November 29, 2024 11:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
ちょっとだけこっちで変えさせていただこうと思います!

こういうこともあったのでchromaticをなくすのはもう少し先でも良いかなと思ってます↓
(実際ChromaticだけじゃなくStorybookも動かなかったやつ)

まあでも、テスト経路を作ってるから残してるくらいの意図で、なかったら作ってないだろうなーくらいの温度感です 🙏

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 2646307 into VOICEVOX:main Nov 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants