Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINEのログをVOICEVOX側のログに出力 #281

Merged
merged 9 commits into from
Sep 30, 2021

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Sep 29, 2021

内容

#280 の差分を含んでいます。

VOICEVOXが起動したENGINEの標準出力・標準エラー出力を、VOICEVOX側のログに出力するようにします。

ENGINEからのログ出力を取得するため、ENGINEのプロセス起動関数を、execFileからspawnに変更しています。

@aoirint aoirint changed the title ENGINEのログを出力 ENGINEのログをVOICEVOX側のログに出力 Sep 29, 2021
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! windowsで問題なく動作することを確認しました。
コンフリクトだけ直して頂けると!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit 34aced4 into VOICEVOX:main Sep 30, 2021
@aoirint aoirint deleted the patch-engine-logging-spawn branch February 28, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants