Undo/Redoの記録を無効化可能に #285
Merged
Undo/Redoの記録を無効化可能に #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#233で私が実装したUndo/Redoの実装で、ImmerとVueのProxyの衝突を避けるためにState全体のコピーを撮っています。この処理はStateの大きさに従って計算コストが掛かるため製品版では問題になることが予測されます。
このプルリクエストではUndo/Redoの記録をとるかどうかのフラグをStateにおくことで、製品版ではUndo/Redoの記録をとらないようにします。
関連 Issue
ref #116
スクリーンショット・動画など
その他
実験的機能としての選択は
IMPORT_TEXTやPUT_TEXT等を移行してから実装すべきだと思ったので、このプルリクエストでは実装していません。