Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.7.0 へのマイグレーション追加 #314

Merged
merged 3 commits into from
Oct 9, 2021
Merged

0.7.0 へのマイグレーション追加 #314

merged 3 commits into from
Oct 9, 2021

Conversation

raa0121
Copy link
Contributor

@raa0121 raa0121 commented Oct 9, 2021

内容

0.7.0 へのマイグレーションを追加しました
characterIndex を speaker に変換します

関連 Issue

ref #229

Hiroshiba
Hiroshiba requested changes Oct 9, 2021
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

単純明快なPR、ありがとうございます！

ノーマルにするか同じ音声スタイルにするか少し迷ったのですが、ユーザは一番似ている声で生成されることを望まれそうなので、あまあま（0と1）に飛ばすのが良さそうに感じました。
そちらだけ修正お願いします・・・！

@raa0121
Copy link
Contributor Author

raa0121 commented Oct 9, 2021

なるほど ノーマルはたしかに少しハキハキしてますね。
修正します。

Hiroshiba
Hiroshiba reviewed Oct 9, 2021
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

四国めたんのあまあまは0、ずんだもんのあまあまは1かも？

@raa0121
Copy link
Contributor Author

raa0121 commented Oct 9, 2021

2回も間違えてすいません orz
直しました

Hiroshiba
Hiroshiba approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！　助かりました、ありがとうございます！！

@Hiroshiba Hiroshiba merged commit 28eb2b8 into VOICEVOX:main Oct 9, 2021
@raa0121 raa0121 deleted the migration-to-0.7.0 branch October 9, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raa0121 @Hiroshiba