vue-gtmの有効化・およびテレメトリー収集のダイアログの追加 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when refuse retrieve telemetry in SettingDialog
Hiroshiba
approved these changes
Dec 10, 2021
y-chan
reviewed
Dec 10, 2021
| </q-card-section> | ||
|
|
||
| <q-card-section class="text-body1"> | ||
| <p>ダミープライバシーポリシー</p> |
There was a problem hiding this comment.
マージされてからのレビューで申し訳ないのですが、ダミープライバシーポリシーをMarkdownで記述できる形にし、それを表示すべきかなと思いました。
そうすれば、voicevox_resourceリポジトリにプライバシーポリシーを置いておき、製品版リソースマージで簡単に置き換えが出来ると思います....!
There was a problem hiding this comment.
たしかに、これはOSS版ではデフォルトで動かないので、製品版マージの際にリソースが突っ込めるほうが良さそうだと思いました。
アップデートまでにそうしたいですね！！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue
ref: #487
スクリーンショット・動画など
動画: #487 (comment)