Windowのタイトルにバージョン情報を載せる #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-chan
reviewed
Dec 17, 2021
Co-authored-by: Yuto Ashida <y-chan@y-chan.dev>
Co-authored-by: Yuto Ashida <y-chan@y-chan.dev>
|
バージョン表記を Ver. に変更しました |
y-chan
approved these changes
Dec 17, 2021
Closed
MT224244
approved these changes
Dec 19, 2021
| @@ -18,7 +18,8 @@ | |||
| {{ | |||
| (isEdited ? "*" : "") + | |||
| (projectName !== undefined ? projectName + " - " : "") + | |||
| "VOICEVOX" | |||
| "VOICEVOX" + | |||
| (currentVersion ? " - Ver. " + currentVersion : "") | |||
There was a problem hiding this comment.
タイトルバーはプロジェクト名も入るので出来るだけ短い方がいいかな(Ver. 0.9.3 -> v0.9.3)と思いましたが、4文字くらいならそこまで変わらないかなとも思うのでこのままでも良さそうです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
windowのタイトルにバージョン情報を載せます。
関連 Issue
ref #581
スクリーンショット・動画など