openapiのコード生成を行った #613
Merged
openapiのコード生成を行った #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openapiのコード生成を行った refs VOICEVOX#608 VOICEVOX#610
qwerty2501
commented
Dec 20, 2021
| 5.3.0 |
There was a problem hiding this comment.
やはりgeneratorのバージョンが上がってるようですね。
| @@ -43,7 +43,7 @@ export interface AccentPhrase { | |||
| * @type {Mora} | |||
| * @memberof AccentPhrase | |||
| */ | |||
| pauseMora?: Mora; | |||
| pauseMora?: Mora | null; | |||
There was a problem hiding this comment.
nullが追加されてしまっている
|
なんでバージョンが違うようになるのかわからないんですよねー･･･ openapi-generator-cli のパッケージはこちらっぽいです 書いてることを読んだ感じ、 |
|
たぶんそこまで大々的に変わることはないので、5.3.0で固定しちゃいましょうか！ |
Hiroshiba
reviewed
Dec 20, 2021
設定追加して固定化させました |
Hiroshiba
approved these changes
Dec 20, 2021
|
openapi周りは深い知識持っている方がおらずよくわからないのが本音なので、テスト通ったらえいやでマージしちゃおうと思います。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#610 で生成したコードの差分がなんか多すぎる気がしたため、一度openapiのコード生成のみをレビューしていただきたくPR作ります
関連 Issue
refs #610 #608