[HOTFIX]再生位置を指定するコードを移動させる #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Mar 1, 2022
Hiroshiba
added a commit
that referenced
this pull request
Mar 1, 2022
* To 0.11.0 (#720) * アプデ情報の情報整理 * GTM情報を書き換える * デザイン調整 * アプデ情報追加 * update htu * 辞書読み上げを最初のキャラに * electron builderでは、.envファイルが読み込まれないっぽい？のでフォールバック (#722) * Hotfix: バイナリでエンジン設定が読み出せず、エンジンが起動しない問題の原因を修正 (#721) (#723) * use process.env.DEFAULT_ENGINE_INFOS after dotenv.config * fix comment * fix comment * to 0.11.2 (#725) * [HOTFIX]再生位置を指定するコードを移動させる (#733) * move part of setting current time * Update src/store/audio.ts Co-authored-by: Hiroshiba <hihokaruta@gmail.com> * [HOSTFIX] #730を修正 (#735) * 辞書UIの状態遷移を整理 (#736) * 辞書UIの状態遷移を整理 * closeDialog * selectWord * to-0.11.3 Co-authored-by: aoirint <aoirint@gmail.com> Co-authored-by: Yuto Ashida <y-chan@y-chan.dev> Co-authored-by: madosuki <yurikasamaaikatsu@gmail.com>
Hiroshiba
added a commit
that referenced
this pull request
Mar 19, 2022
* To 0.11.0 (#720) * アプデ情報の情報整理 * GTM情報を書き換える * デザイン調整 * アプデ情報追加 * update htu * 辞書読み上げを最初のキャラに * electron builderでは、.envファイルが読み込まれないっぽい？のでフォールバック (#722) * Hotfix: バイナリでエンジン設定が読み出せず、エンジンが起動しない問題の原因を修正 (#721) (#723) * use process.env.DEFAULT_ENGINE_INFOS after dotenv.config * fix comment * fix comment * to 0.11.2 (#725) * [HOTFIX]再生位置を指定するコードを移動させる (#733) * move part of setting current time * Update src/store/audio.ts Co-authored-by: Hiroshiba <hihokaruta@gmail.com> * [HOSTFIX] #730を修正 (#735) * 辞書UIの状態遷移を整理 (#736) * 辞書UIの状態遷移を整理 * closeDialog * selectWord * to-0.11.3 * to 0.11.4 (#760) * updateinfoのミス修正 (#764) Co-authored-by: aoirint <aoirint@gmail.com> Co-authored-by: Yuto Ashida <y-chan@y-chan.dev> Co-authored-by: madosuki <yurikasamaaikatsu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
BlobとAudioElementだけで再生させられるようにリファクタを行いましたが、
currentTimeをセットしてからsrcをセットするとcurrentTimeの方がリセットされてしまうようなので、そうならないようにcurrentTimeをセットするコードを移動させました。しっかり動作確認せずにPRしてしまった私の問題です、ご迷惑をおかけしました...
関連 Issue
close #732