Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

複数エンジン対応:INITIALIZE_ENGINE_SPEAKERの修正漏れを修正 #928

Merged

Conversation

sevenc-nanashi
Copy link
Member

内容

voicevox/src/store/audio.ts

Lines 717 to 721 in 5482e27

async INITIALIZE_ENGINE_SPEAKER({ state, dispatch }, { styleId }) {
const engineId: string | undefined = state.engineIds[0]; // TODO: 複数エンジン対応, 暫定的に0番目のエンジンのみを使用する。将来的にGENERATE_AUDIO_ITEMの引数にengineId/engineIdを追加する予定
if (engineId === undefined)
throw new Error(`No such engine registered: index == 0`);

が更新されていないのを修正します。

voicevox/src/store/audio.ts

Lines 746 to 749 in 5482e27

await dispatch("INITIALIZE_ENGINE_SPEAKER", {
engineId,
styleId,
}).finally(() => {

でengineIdつきで呼び出されていることから修正漏れと判断しました。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

気づけませんでした、ありがとうございます!

@Hiroshiba Hiroshiba merged commit 1d25170 into VOICEVOX:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants