engineProcessのundefinedチェックを追加 #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Hiroshiba
reviewed
Sep 10, 2022
src/background.ts
Outdated
| reject(); | ||
| } | ||
| }); | ||
| if (engineProcess) { |
There was a problem hiding this comment.
engineProcessがundefinedのときは、エンジンの起動に失敗した場合っぽいです。
参考↓
Lines 622 to 626 in ab72c91
その場合でもrestartEngine（この関数）の通りエンジンを起動しようとするのが良いのかなと思いました！
でもそれを実装していただくのはちょっとPRの内容に合致しないですね･･･↓のTODOコメントsuggestionを採用いただくだけでもOKです！
Suggested change
| if (engineProcess) { | |
| // TODO: engineProcessがundefinedのときもエンジンを起動する | |
| if (engineProcess) { |
There was a problem hiding this comment.
すみません、上のif文を見逃してました。。
ここでengineProcess==undefinedはあり得ない、ということがわかるように、throwにして頂ければ！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
すぐ上でreturnしているので動作上の影響は無さそうでしたが、型的にはundefinedの可能性があるとしてエラーが出ていたので修正しました。