Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

右端のスライダーツールチップが見切れないようにした #952

Merged
merged 1 commit into from
Sep 26, 2022
Merged

右端のスライダーツールチップが見切れないようにした #952

merged 1 commit into from
Sep 26, 2022

Conversation

k-chop
Copy link
Contributor

@k-chop k-chop commented Sep 23, 2022

内容

右端にのみ余白を追加してスライダーのツールチップが見切れないようにしました。
cssのlast-childセレクタで実現しています。

関連 Issue

close #857

動作確認

  • 下ペインに横スクロールバーが出る状態で、右端のスライダーツールチップが見切れないことを確認
  • 右端以外に影響が出ないことを確認

スクリーンショット・動画など

before

2

after

1

after他のタブ

a1
a2
a3

Hiroshiba
Hiroshiba approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

CSS何もわからなかったのですが、こんなに簡単に実現できるもんなんですね･･･。

y-chan
y-chan approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！
マージしてしまいますね！

@y-chan y-chan merged commit 32914eb into VOICEVOX:main Sep 26, 2022
@k-chop k-chop deleted the issue857/add-margin-to-right branch September 27, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

画面右端に余白が足りず数値を読み取れない
3 participants
@k-chop @Hiroshiba @y-chan