Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

複数エンジン対応:engineManifestで実行時引数を指定できるように #995

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

sevenc-nanashi
Copy link
Member

内容

engine_manifest.jsonのcommandsフィールドをnode-shlexで分割し、引数を指定できるようにします。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

そもそもエンジン側のcommandexecutionCommandexecutionArgsに分けても良いかもとちょっと思いました。

@Hiroshiba
Copy link
Member

問題ないと思うのでマージします!

@Hiroshiba Hiroshiba merged commit ee54b91 into VOICEVOX:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants