Migrate: Poetryに移行 #652
Merged
Migrate: Poetryに移行 #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Oct 21, 2023
| @@ -2,6 +2,18 @@ | |||
| name = "voicevox_core" | |||
| requires-python = ">=3.8" | |||
| dependencies = ["numpy", "pydantic>=1.9.2,<2"] | |||
| description = "VOICEVOX CORE の Python バインディングです。" | |||
| authors = [{ name = "Hiroshiba", email = "hihokaruta@gmail.com" }] | |||
There was a problem hiding this comment.
これそのうちvoicevox用のに一斉に変えたいですね！
とりあえずまだ決まってないのでこれで。
qryxip
reviewed
Oct 22, 2023
Co-authored-by: Ryo Yamashita <qryxip@gmail.com>
|
@sevenc-nanashi 以下の2つが無言resolveになっている件、これは単純な疑問なのですが、そちらに未pushのコミットがあったりしませんか? |
|
ありました！ごめんなさい |
qryxip
reviewed
Oct 22, 2023
qryxip
reviewed
Oct 22, 2023
| "Operating System :: POSIX :: Linux", | ||
| "Operating System :: Microsoft :: Windows", | ||
| "Operating System :: MacOS :: MacOS X", | ||
| "Environment :: GPU :: NVIDIA CUDA", |
There was a problem hiding this comment.
私は詳しくないのですが、この記述はどちらかというと"CUDA"が必要という方向を意味したりしないでしょうか?
例えばonnxruntime-gpuとかではこの指定は無いようです。
There was a problem hiding this comment.
なんかタグっぽみ。･･･個人的にはまあもう完全にどっちでもいいかなと思いました！！
https://pypi.org/classifiers/
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
requirements-*.txtを爆破してPoetryのDependency Groupに移行します。
メインの依存はメジャーバージョン範囲内、開発依存は固定しています。
関連 Issue
その他
（なし）