Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-s] ダミーモデルの追加とテストの有効化 #736

Merged

Conversation

y-chan
Copy link
Member

@y-chan y-chan commented Jan 27, 2024

内容

題の通りです

関連 Issue

ref #734

その他

モデルの読み込みに関するテストを追加しています。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よくわかってないのですが、typosとかのテストが落ちてそうでした!

crates/voicevox_core/src/status/model_file.rs Outdated Show resolved Hide resolved
@y-chan
Copy link
Member Author

y-chan commented Jan 28, 2024

typosの修正、モデルのリネーム、対応しました...!

@Hiroshiba
Copy link
Member

cargo fmt忘れでrust-lintが落ちてたのでこちらで直させていただきます!
(VSCodeの保存時フォーマットおすすめです)

@Hiroshiba Hiroshiba merged commit ca585b2 into VOICEVOX:release-0.15 Jan 28, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants