Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Renovateのdatasourceをgithub-tagsにする #819

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Aug 12, 2024

内容

最近rust-lang/rustの緊急パッチリリース (e.g. 最近の1.80.1)はGitHub Releaseの方から出ない傾向にあり、今のRenovateの設定だと反応しません。そのため設定のdatasourceTemplategithub-releasesからgithub-tagsに変えることで拾えるようにします。

image

関連 Issue

#817 に依存します。

その他

@qryxip qryxip mentioned this pull request Aug 12, 2024
@qryxip qryxip marked this pull request as draft August 12, 2024 07:16
@qryxip qryxip force-pushed the ci-change-datasource-template-to-github-tags branch from 031ec2c to ef1349c Compare August 12, 2024 15:10
@qryxip qryxip marked this pull request as ready for review August 12, 2024 15:10
@qryxip qryxip requested a review from Hiroshiba August 12, 2024 15:10
@@ -35,7 +35,7 @@
],
"depNameTemplate": "Rust",
"packageNameTemplate": "rust-lang/rust",
"datasourceTemplate": "github-releases"
"datasourceTemplate": "github-tags"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、ちゃんと仕様を把握していないのですが、これってベータ版のRustがリリースされた時も更新通知が来たりしそうでしょうか・・・?

とはいえ別に致命傷にならないので、1回マージしてみて思ってた挙動と違ってたら直すとかでもありだと思います!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/rustのタグは現在だとStableのリリース (1\.\d+\.\d+)のみに限られているはずです。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おお、なるほどです!! 大丈夫そう!!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点コメントしましたが、そこが問題なければLGTMです!!

@qryxip qryxip merged commit 983f2e1 into VOICEVOX:main Aug 13, 2024
30 checks passed
@qryxip qryxip deleted the ci-change-datasource-template-to-github-tags branch August 13, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants