Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectML対応によるActionsの問題の修正 #92

Merged
merged 14 commits into from
Mar 11, 2022

Conversation

Oyaki122
Copy link
Member

内容

Actionsでonnxruntimeをダウンロードする際、ファイルコピーのパスをDirectMLに合わせた事によって通常版でのコピーに失敗していたので、修正しました

その他

Actionsのcacheによってダウンロードがスキップされていたことでこちらのリポジトリでは問題が現れませんでした。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます!
(ディレクトリ構成が違うの、地味に対応大変なのでVOICEVOXでは気をつけたいですね。。 😇 )

.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

もうマージしても大丈夫という認識なのですが、認識あってそうでしょうか👀

@Oyaki122
Copy link
Member Author

マージして構いません

@Hiroshiba Hiroshiba merged commit b8651d8 into VOICEVOX:main Mar 11, 2022
@Oyaki122 Oyaki122 deleted the fix_build branch March 14, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants