Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.15] #857 をrevert #1023

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

Hiroshiba
Copy link
Member

内容

の問題の一旦の解決として、

をrevertします。

  • pyinstallerがv5に戻る
  • run.specを引数でonnxruntimeなどのパスを渡す形がもとに戻る(環境変数経由)
  • internal_root関数がenigine_rootに戻る

build.ymlの形が変わる(戻る)のですが、 #857 以降コミットがないので大丈夫だと判断しました。
internal_root関数は追加で使われてい無さそうでした。

関連 Issue

その他

とりあえずマージ&0.15.1としてビルドし、動くかどうかチェックしてみます。

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 21, 2024 08:08
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team January 21, 2024 08:08
@Hiroshiba
Copy link
Member Author

@sabonerune 共有です。
こちらのチェックが甘く、緊急revertとなりとても申し訳ないです・・・ 🙇 🙇 🙇

Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 484 312 coverage-36%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 94 72 coverage-23%
voicevox_engine/core_adapter.py 60 17 coverage-72%
voicevox_engine/core_initializer.py 59 30 coverage-49%
voicevox_engine/core_wrapper.py 225 159 coverage-29%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 36 8 coverage-78%
voicevox_engine/dev/tts_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 28 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 92 4 coverage-96%
voicevox_engine/metas/Metas.py 34 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 6 coverage-67%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 164 9 coverage-95%
voicevox_engine/morphing.py 71 46 coverage-35%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 13 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 80 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 17 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 34 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 88 1 coverage-99%
voicevox_engine/tts_pipeline/mora_list.py 7 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 146 6 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 177 11 coverage-94%
voicevox_engine/user_dict.py 145 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2252 711 coverage-68%

@Hiroshiba Hiroshiba changed the title [release-0.15] [release-0.15] #857 をrevert Jan 21, 2024
@Hiroshiba Hiroshiba merged commit e9d805b into VOICEVOX:release-0.15 Jan 21, 2024
3 checks passed
@Hiroshiba Hiroshiba deleted the revert-4ef4218 branch January 21, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant