Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: エンジンマニフェストをマージするためのスクリプトを追加 #1482

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Hiroshiba
Copy link
Member

内容

エンジンマニフェストの、supported featuresをいい感じにマージするためのスクリプトを書いてみました。

の解決のための1手目です。

関連 Issue

#1481

その他

このプルリクエストをマージした後、VOICEVOX RESOURCE側でmanage_libraryをfalseにし、エンジンをリビルドすれば #1481 は解決なはずです。

@Hiroshiba Hiroshiba requested a review from a team as a code owner November 15, 2024 04:12
Copy link
Member Author

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとわからないけど大丈夫な気がするのでマージします!!

@Hiroshiba Hiroshiba merged commit 7f4c47a into VOICEVOX:master Nov 15, 2024
4 checks passed
@Hiroshiba Hiroshiba deleted the merge-engine-manifest.py branch November 15, 2024 13:46
@Hiroshiba
Copy link
Member Author

manage_libraryがまだfalseじゃない(元になったissueはまだ解決しない)ですが、とりあえずエラーになるかは↓のWorkflowで判別できるはず。
https://github.com/VOICEVOX/voicevox_engine/actions/runs/11857408395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant