Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: 未処理の例外が発生した場合スタックトレースが表示されない問題を修正 #1487

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions voicevox_engine/app/middlewares.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import re
import sys
from collections.abc import Awaitable, Callable
from traceback import print_exception

from fastapi import FastAPI, Request, Response
from fastapi.middleware.cors import CORSMiddleware
Expand All @@ -20,6 +21,7 @@ def configure_middlewares(
# 未処理の例外が発生するとCORSMiddlewareが適用されない問題に対するワークアラウンド
# ref: https://github.com/VOICEVOX/voicevox_engine/issues/91
async def global_execution_handler(request: Request, exc: Exception) -> Response:
print_exception(exc)
takana-v marked this conversation as resolved.
Show resolved Hide resolved
return JSONResponse(
status_code=500,
content="Internal Server Error",
Expand Down