Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: 依存パッケージの更新 #1488

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sabonerune
Copy link
Contributor

内容

エディタ側の更新作業が行われたのでエンジン側も更新作業を行います。

関連 Issue

その他

PyInstallerとNumpy以外の上げられるパッケージを更新しました。

  • pre-commitのstages: [push]が非推奨になっていたためstages: [pre-push]へ更新。
  • OpenAPIのスキーマーが変わっていますが意味的には変わっていないはずなので問題ないはず?

忘備録

@sabonerune sabonerune requested a review from a team as a code owner November 21, 2024 14:35
@sabonerune sabonerune requested review from Hiroshiba and removed request for a team November 21, 2024 14:35
@Hiroshiba
Copy link
Member

OpenAPIのスキーマーが変わっていますが意味的には変わっていないはずなので問題ないはず?

念のために、エディター側のopenapi.jsonが変わってないことを確認しました!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit cf25ebf into VOICEVOX:master Nov 22, 2024
4 checks passed
@sabonerune sabonerune deleted the maint/update-deps branch November 23, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants