MNT: Safetyの代わりにpip-auditを使う
#1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jan 23, 2025
There was a problem hiding this comment.
更新ありがとうございます！
pip-auditを依存に加えるの良いですね！！ 思いつきませんでした 🙏
CONTRIBUTING.mdにsafetyの説明があったので、こちらも変更お願いしてもよいでしょうか･･･！
https://github.com/sabonerune/voicevox_engine/blob/65f8fa4565a822c9419ccce3d1067786e4ae39a7/CONTRIBUTING.md?plain=1#L325-L332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
safety checkコマンドが非推奨になっていたためこれを置き換えます。Safetyの案内する置き換え先は
safety scanコマンドですがログインが必要なためpip-auditを使用します。関連 Issue
safety checkコマンドが非推奨になっている #1517その他
no-depsを使うと依存の解決が省略されるので速くなるというドキュメントがあったのですがあまり変わらなそうでしたので使用しませんでした。pip-auditを依存関係に追加せずに実行することも考えましたがローカルで実行できるようにするために依存に追加しています。