-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS用自動ビルド: ONNX版コアに対応 #257
Merged
Hiroshiba
merged 15 commits into
VOICEVOX:master
from
aoirint:patch-onnx-autobuild-macos
Dec 31, 2021
Merged
macOS用自動ビルド: ONNX版コアに対応 #257
Hiroshiba
merged 15 commits into
VOICEVOX:master
from
aoirint:patch-onnx-autobuild-macos
Dec 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1636739389
💛 - Coveralls |
PickledChair
approved these changes
Dec 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ビルド産物についても、エンジンの動作や、共有ライブラリの不足がないかなどを手元の環境でチェックしました。問題ないようです👍
Hiroshiba
approved these changes
Dec 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
(PickledChairさん確認ありがとうございます!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
macOS用自動ビルドをONNX版コア(0.10.preview.0)に対応させます。
fork先で自動ビルドされたバイナリでの動作を確認したらDraftを外します。
ノート
関連 Issue
スクリーンショット・動画など
その他