対応デバイスが分かるAPIエンドポイントを追加 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ResultResultを開く
|
Pull Request Test Coverage Report for Build 1789403383
💛 - Coveralls |
Hiroshiba
reviewed
Jan 25, 2022
run.py
Outdated
| @@ -535,6 +535,18 @@ def speaker_info(speaker_uuid: str, core_version: Optional[str] = None): | |||
| ret_data = {"policy": policy, "portrait": portrait, "style_infos": style_infos} | |||
| return ret_data | |||
|
|
|||
| @app.get("/supported_devices", response_model=List[Speaker], tags=["その他"]) | |||
There was a problem hiding this comment.
response_modelの存在を忘れていました...
とりあえず手元では{"cpu": bool, "cuda": bool}の形だったので、それに合わせて追記しました。
Hiroshiba
reviewed
Feb 1, 2022
| @@ -160,15 +161,26 @@ def __init__( | |||
| return: 音声波形 | |||
|
|
|||
| speakers: coreから取得したspeakersに関するjsonデータの文字列 | |||
|
|
|||
| supported_devices: coreから取得した対応デバイスに関するjsonデータの文字列 | |||
There was a problem hiding this comment.
おそらくNoneのときに意味を持っている設計だと思うので、その説明があると良いのかなと思いました。
（Noneのときはすべてのデバイスでサポートしているか不明です、みたいな）
Hiroshiba
reviewed
Feb 1, 2022
| try: | ||
| supported_devices = core.supported_devices() | ||
| except NameError: | ||
| supported_devices = None |
There was a problem hiding this comment.
pytorch版にはこの関数がないのでこのエラーが出るので、何がサポートされているかわからないという意味のNoneを代入みたいな、意図のコメントがあったほうが良いかなと思いました。
Hiroshiba
requested changes
Feb 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
コアがCPU/GPUモードに対応しているかを返すエンドポイント
/supported_devicesを追加します。関連 Issue
close #246
その他
#254 の変更が含まれていますので、release-0.10へは含めないようにお願いします。